Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add composer component package #107

Merged
merged 2 commits into from Nov 24, 2014
Merged

add composer component package #107

merged 2 commits into from Nov 24, 2014

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Oct 16, 2014

adds support for component and component installer for composer

tested with composer custom repo definition in composer.json:

    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/glensc/blockui"
        }   
    ]
    "require": {
        "components/jquery-blockui": "*@dev",

after PR merge, probably should:

  1. create new git tag (f.e 2.66) in blockui and push it to github (don't forget to update versions in source)
  2. register package on packagist.org

@DiegoYungh
Copy link

I created a fork with all PR I saw here
https://github.com/DiegoYungh/blockui/commits/master

In the near future I will probably create a block feature on top of blockui and open to pull requests

@glensc
Copy link
Contributor Author

glensc commented Nov 22, 2014

@DiegoYungh your fork is lousy. you should had used original commits from this repo keeping original authors!

@DiegoYungh
Copy link

@glensc can't seem to pull these request, I'd love to have merged then in a prettier way.
but in any case the records are in the commits

@glensc
Copy link
Contributor Author

glensc commented Nov 22, 2014

@glensc
Copy link
Contributor Author

glensc commented Nov 22, 2014

@DiegoYungh
Copy link

Nice, I will recreate with the same name, everything merged

@glensc
Copy link
Contributor Author

glensc commented Nov 22, 2014

you can just git reset b38dd8f add your commits and git push -f to overwrite github push

@DiegoYungh
Copy link

hahaha that's fantasgit!
The only one I can't merge is #47 , no way... really
check in a few minutes I will have a updated fork

Appart from that, I plan on changing a little blockUI, keeping the core/cross-browser treatment on the overlay and stuff, but changing the API to be more flexible, update status messages in the way, plus AMD support and bla bla bla...

Thanks a lot 👍

@glensc
Copy link
Contributor Author

glensc commented Nov 22, 2014

and why the fork? did @malsup say he doesn't maintain anymore? maybe he can add you collabrator instead?

@DiegoYungh
Copy link

I actually sent him a mail, and he was last summoned on github in oct.7
With this many Issues and Stuff I imagine he is working on another project, or in a company that does not allow him some spare time to come here.

@malsup
Copy link
Owner

malsup commented Nov 24, 2014

Yeah, I've been crazy busy lately. But most of the outstanding PRs look like I can one-click merge them into master (except 47).

malsup added a commit that referenced this pull request Nov 24, 2014
add composer component package
@malsup malsup merged commit 054596f into malsup:master Nov 24, 2014
@glensc glensc deleted the component branch November 24, 2014 15:22
@glensc
Copy link
Contributor Author

glensc commented Nov 24, 2014

Would you mind pushing out new version tag once you're done. as that's what composer (and maybe others) use for versioning.

@malsup
Copy link
Owner

malsup commented Nov 25, 2014

New tag pushed.

@glensc glensc restored the component branch November 25, 2014 14:05
@glensc glensc deleted the component branch October 11, 2015 14:29
@glensc
Copy link
Contributor Author

glensc commented Oct 11, 2015

i don't see you created composer integration for this package

https://packagist.org/search/?q=malsup

i see only malsup/form there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants