Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion for two additional options: showOverlayDelay and stopAnimationInProgress #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nbelaevski
Copy link

Hello,

This pull request covers implementation for two additional options that I suggest for addition to BlockUI. Their purpose is to get little more control over BlockUI animation.

  • showOverlayDelay - allows the developer to introduce additional delay before fading in overlay and message. During the delay UI is blocked and 'wait' cursor is shown, but overlay is not visible (transparent). Default value is 0 - no additional delay.
  • stopAnimationInProgress - allows the developer to stop running animation before uninstallation of screen blocker. Without this option jQuery fades in overlay and message completely before fading out, so this looks like an unwanted effect for us. If stopAnimationInProgress is true and message hasn't been faded in completely at the point when unblock has been called, then it's fading out from its current state. Default value is false.

Please take a look and let me know what you think.

- showOverlayDelay
- stopAnimationInProgress
@libryder
Copy link

libryder commented Dec 9, 2011

Awesome! Tested and works great. Using this now, thanks :)

@DiegoYungh
Copy link

I created a fork with all PR I saw here
https://github.com/DiegoYungh/blockui/commits/master

In the near future I will probably create a block feature on top of blockui and open to pull requests

@cristian-codorean
Copy link

@DiegoYungh, was this specific PR merged into your fork ? I can't seem to find it in there, but I'm kind of new to github, so I might have not looked in the right place.
Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants