-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add active class at beginning of transition #36
Comments
You can now control when updateView is invoked. |
Reverted this feature since it broke a few things. Need to give this some more thought. |
Ok, have it working now. |
Works perfectly. Thank you for including it! |
Hi There, I'm just picking up on this thread as it's exactly the functionality i'm looking for. Is there an example or you you direct to to how i can achieve this with the API? Many thanks |
Apologies, i've just seen in the documentation how to achieve this. |
Move the assignation of the active class to when the transition starts. At the moment the active class becomes assigned after the the transition has completed – which can look not so smooth.
I have a carousel nav that controls a slideshow and when an item in the carousel is clicked I think the user will expect the state to change then not when the transition has completed.
I looked at the code, but I couldn't seem to switch the order of opts.API.updateView(); without breaking the active class totally.
I hope that makes sense?
Many thanks,
Shaun
The text was updated successfully, but these errors were encountered: