Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

height/width values for scrollbars get overridden #15

Closed
lifeifei opened this issue Jan 20, 2016 · 6 comments
Closed

height/width values for scrollbars get overridden #15

lifeifei opened this issue Jan 20, 2016 · 6 comments
Labels

Comments

@lifeifei
Copy link

We would like to change the horizontal scrollbar height as it looks smaller than the normal scrollbar in IE. At this moment, the height is hard coded in your code. Is there any way that we can customise it?

@malte-wessel
Copy link
Owner

Yes, that's easy!

<Scrollbars
  renderScrollbarHorizontal={(style, ...props) =>
    <div style={{...style, height: 10 }} {...props}/>
  }/>

Check out the customization section in the README

@lifeifei
Copy link
Author

Hi,

I still get '6px' height for the horizontal scrollbar after using the above code. Other customised styles work fine except the height as I guess it was overridden by your code when rendering. Can you please confirm it? Thanks!

Lifei

@malte-wessel
Copy link
Owner

Oh, you're right, I'll fix it soon!

@malte-wessel malte-wessel added bug and removed question labels Jan 22, 2016
@malte-wessel malte-wessel changed the title Customise height for the horizontal scrollbar height/width values for scrollbars gets overridden Jan 22, 2016
@malte-wessel malte-wessel changed the title height/width values for scrollbars gets overridden height/width values for scrollbars get overridden Jan 22, 2016
@lifeifei
Copy link
Author

I've forked your repo and fixing now. Would you like me to create a pull request after the fix?

@malte-wessel
Copy link
Owner

There are some other things, related to that specific code, that I'd also like to fix. So you don't need to make a PR. I'll fix this issue on the weekend.

@malte-wessel
Copy link
Owner

This should work now! Thx for reporting!

malte-wessel pushed a commit that referenced this issue Jan 30, 2016
* master:
  style tweaks
  added shadow example
  bump v.2.2.2
  removed redundant code, added warnings
  bump v2.2.1
  removed unused methods
  bump v2.2.0
  fix #15 and clean up
  Update CHANGELOG.md
  Update README.md
  more tests
  more tests
  improve tests
  more tests
  added tests
  added karma
  bump v2.1.2
  cancel animation frame when component will unmount
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants