Skip to content

Commit

Permalink
Fix names of dependencies.
Browse files Browse the repository at this point in the history
The dependencies have been named ``importlib.resources`` and
``importlib.metadata`` - with dots, making them look like module names.  This
caused ``ContextualVersionConflict``s in some setups (see below). Replacing
the names by an underscore, like the name of the packages at PyPI have, solved
this problem.

pkg_resources.ContextualVersionConflict:
(importlib-resources 5.12.0 (…/myproj/.eggs/importlib_resources-5.12.0-py3.7.egg),
Requirement.parse('importlib.resources; python_version < "3.9"'), {'chameleon'})
  • Loading branch information
htgoebel committed Dec 8, 2023
1 parent 9e809d4 commit ea6f4cd
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
7 changes: 7 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
Changes
=======

In next release ...

- Fix names of dependencies for ``importlib_resources`` and
``importlib_metadata``.
(``#394 <https://github.com/malthe/chameleon/pull/394>`_)
4.3.0 (2023-12-04)
------------------
Expand Down
4 changes: 2 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
CHANGES = ''

install_requires = [
'importlib.metadata;python_version<"3.10"',
'importlib.resources;python_version<"3.9"']
'importlib-metadata;python_version<"3.10"',
'importlib-resources;python_version<"3.9"']


class Benchmark(test):
Expand Down

0 comments on commit ea6f4cd

Please sign in to comment.