-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace pkg_resources #358
Conversation
This will most likely fail for packages where the resources have to be extracted, as the used context wrapper will cleanup upon exit and the current |
@fschulze seems this is almost there? what remains here before we can merge |
See my last comment. It fails for packages which have the templates zipped. I'm also not sure whether that case is covered by tests yet (and how hard such tests would be to implement/simulate). |
@fschulze that makes sense – perhaps we should shift this way of loading a file-based template to the But one question, doesn't the current code also fail with zipped templates? |
I will most likely work on that this week. |
1fd9444
to
18e39dc
Compare
Pull Request Test Coverage Report for Build 6840603550
💛 - Coveralls |
9a22b8c
to
177e664
Compare
The spec is now stored on the template and handled properly. The filename attribute is now marked as deprecated. |
b1c620e
to
46a4e5a
Compare
46a4e5a
to
b67aa5b
Compare
b67aa5b
to
e628569
Compare
Just importing pkg_resources becomes slower and slower the more packages are installed. Even on fast machines with SSDs this can add a second or more to the startup time.