Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix names of dependencies. #394

Merged
merged 1 commit into from Dec 8, 2023
Merged

Fix names of dependencies. #394

merged 1 commit into from Dec 8, 2023

Conversation

htgoebel
Copy link
Contributor

@htgoebel htgoebel commented Dec 8, 2023

The dependencies have been named importlib.resources and importlib.metadata - with dots, making them look like module names. This caused ContextualVersionConflicts in some setups (see below). Replacing the names by an underscore, like the name of the packages at PyPI have, solved this problem.

This happend when running in under tox -e py37 where the actual test command is python setup.py test:

pkg_resources.ContextualVersionConflict:
(importlib-resources 5.12.0 (…/myproj/.eggs/importlib_resources-5.12.0-py3.7.egg),
Requirement.parse('importlib.resources; python_version < "3.9"'), {'chameleon'})

@htgoebel
Fix names of dependencies.
ea6f4cd 
The dependencies have been named ``importlib.resources`` and
``importlib.metadata`` - with dots, making them look like module names.  This
caused ``ContextualVersionConflict``s in some setups (see below). Replacing
the names by an underscore, like the name of the packages at PyPI have, solved
this problem.

pkg_resources.ContextualVersionConflict:
(importlib-resources 5.12.0 (…/myproj/.eggs/importlib_resources-5.12.0-py3.7.egg),
Requirement.parse('importlib.resources; python_version < "3.9"'), {'chameleon'})
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7141142307

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.488%
Totals Coverage Status
Change from base Build 7086289541: 0.0%
Covered Lines: 4256
Relevant Lines: 4759
💛 - Coveralls

@malthe malthe merged commit a075c59 into malthe:master Dec 8, 2023
11 checks passed
@htgoebel
Copy link
Contributor Author

htgoebel commented Dec 8, 2023

Wow. thanks for applying that quickly!

credfeto added a commit to credfeto/LiveBandPhotosCom that referenced this pull request Dec 13, 2023
@credfeto
[Dependencies]: Bump chameleon from 4.3.0 to 4.4.0 (#388)
9bc9a08 
Bumps [chameleon](https://github.com/malthe/chameleon) from 4.3.0 to
4.4.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/malthe/chameleon/releases">chameleon's
releases</a>.</em></p>
<blockquote>
<h2>4.4.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Make imports absolute by <a
href="https://github.com/malthe"><code>@​malthe</code></a> in <a
href="https://redirect.github.com/malthe/chameleon/pull/393">malthe/chameleon#393</a></li>
<li>Fix names of dependencies. by <a
href="https://github.com/htgoebel"><code>@​htgoebel</code></a> in <a
href="https://redirect.github.com/malthe/chameleon/pull/394">malthe/chameleon#394</a></li>
<li>Fix Windows regression by <a
href="https://github.com/malthe"><code>@​malthe</code></a> in <a
href="https://redirect.github.com/malthe/chameleon/pull/396">malthe/chameleon#396</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/htgoebel"><code>@​htgoebel</code></a>
made their first contribution in <a
href="https://redirect.github.com/malthe/chameleon/pull/394">malthe/chameleon#394</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/malthe/chameleon/compare/4.3.0...4.4.0">https://github.com/malthe/chameleon/compare/4.3.0...4.4.0</a></p>
</blockquote>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/malthe/chameleon/blob/master/CHANGES.rst">chameleon's
changelog</a>.</em></p>
<blockquote>
<h2>4.4.0 (2023-12-12)</h2>
<ul>
<li>
<p>Add optional parameter <code>package_name</code> which allows loading
a
template relative to a package.</p>
</li>
<li>
<p>Drop support for Python 3.7.</p>
</li>
<li>
<p>Fix regression where Chameleon would not load templates correctly on
Windows.</p>
</li>
<li>
<p>Fix names of dependencies for <code>importlib_resources</code> and
<code>importlib_metadata</code>.
(<code>[#394](malthe/chameleon#394)
&lt;https://github.com/malthe/chameleon/pull/394&gt;</code>_)</p>
</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/malthe/chameleon/commit/be2eca97c38d7ae68cbddfbbf340e4259b0be892"><code>be2eca9</code></a>
Fix changelog</li>
<li><a
href="https://github.com/malthe/chameleon/commit/324171965929a4224a61dbeb67a7cc1db1be957e"><code>3241719</code></a>
Prepare release</li>
<li><a
href="https://github.com/malthe/chameleon/commit/bedfd67ea48973f4ef70ffada384cbc76712e116"><code>bedfd67</code></a>
Merge pull request <a
href="https://redirect.github.com/malthe/chameleon/issues/396">#396</a>
from malthe/test-windows</li>
<li><a
href="https://github.com/malthe/chameleon/commit/616fe2240d1f3d64e6ad028ab7ac63eb5e319144"><code>616fe22</code></a>
Lint</li>
<li><a
href="https://github.com/malthe/chameleon/commit/512a872490107d1218a3076da0c1bbb123dcdecc"><code>512a872</code></a>
Fix cleanup</li>
<li><a
href="https://github.com/malthe/chameleon/commit/5164a96d5f299b832fec0d0530a9eb747e0d4577"><code>5164a96</code></a>
Manual archive cleanup to reveal bugs on Python &lt; 3.11</li>
<li><a
href="https://github.com/malthe/chameleon/commit/64d00616778ff68bbfe51cbc7de92d234112b6c9"><code>64d0061</code></a>
Split into separate method to clean up automatically</li>
<li><a
href="https://github.com/malthe/chameleon/commit/7b315f7a61261488ab6b4046d0708bac3fba604e"><code>7b315f7</code></a>
Must provide as POSIX path for consistency</li>
<li><a
href="https://github.com/malthe/chameleon/commit/7ef0e58be6f743bc74d2cbda88d856ef9aac2b95"><code>7ef0e58</code></a>
Must convert to POSIX path (not Windows)</li>
<li><a
href="https://github.com/malthe/chameleon/commit/0157521ae583d9b1c1ab68a1ea38ca101afda0e3"><code>0157521</code></a>
Add optional argument 'package_name', allowing the loading relative to a
package</li>
<li>Additional commits viewable in <a
href="https://github.com/malthe/chameleon/compare/4.3.0...4.4.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=chameleon&package-manager=pip&previous-version=4.3.0&new-version=4.4.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>
@malthe malthe mentioned this pull request Dec 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malthe malthe malthe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@htgoebel @coveralls @malthe