Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some receptor combinations can't be selected. #4

Closed
s1120cbxxxx opened this issue Jan 26, 2019 · 8 comments
Closed

Some receptor combinations can't be selected. #4

s1120cbxxxx opened this issue Jan 26, 2019 · 8 comments
Labels
bug Something isn't working

Comments

@s1120cbxxxx
Copy link

s1120cbxxxx commented Jan 26, 2019

Hello

The following combinations can't be selected.

  1. Factor Receptor + Soul Receptor
    can't move Factor receptor to Fodder 3
    9663b1b68cb899e6f5b313de801ce612

  2. Extreceptor + any soul (available at pso2es Emergency)
    can't move Extreceptor to Fodder 5
    7b9667227c4bafed3517d284edc45b57

  3. Soul Receptor + any soul (available at pso2es)
    can't move Soul receptor to Fodder 5
    714ba23ef4c7c846f9268bdc9de4f242

These combinations are actually available.

Thanks for your work! and I'm sorry, my english is not good ...

@malulleybovo malulleybovo added the enhancement New feature or request label Jan 27, 2019
@malulleybovo
Copy link
Owner

Thank you for the note! What you pointed out is in fact due to how the assistant was designed. PSO2es EQ bosses are unpredictable, which makes these combinations you pointed out not frequently available in shop. For instance, soul receptor+vol soul exists but it's very possible that at some point you either won't find it available in shop or will find it for an absurdly high price. Therefore, the assistant assumes these combinations of abilities to not exist and disables them. This is to ensure that the assistant always produces viable formulas that can be followed at any time.

I don't plan on changing this assumption since it's correct behavior by design. But I admit the assistant isn't perfect and so, when I have time I'll try to investigate a way to allow users to tweak that (or force it to happen on the review screen) without changing the assistant design.

**As an additional note, Soul Receptor can be added via Special Ability Factor which does enable any combination with Soul Receptor (not just souls). However, it is most commonly used by purchasing PSO2es drops so this has also been disconsidered in the design of the assistant. Nonetheless, this possibility does encourage investigation as well.

@FireswordMRM
Copy link

FireswordMRM commented Feb 4, 2019

Factor receptor dropped always with Soul receptor on units and minimum 3 slots
Factor receptor dropped always with Soul receptor and Gift receptor on weapons and minimum 4 slots
(Possible buy Dominacio weapon with 3s Factor receptor only with soul receptor via Ethernal Tower exchange shop)

Factor receptor can not be dropped without Soul receptor (but possible via Special Ability Factor on Dominacio series)
Gift receptor can not be dropped without Soul receptor

@malulleybovo
Copy link
Owner

Good point about gift and factor receptors. That's something that completely escaped me. I'll see what can be done about that.

@malulleybovo malulleybovo added bug Something isn't working and removed enhancement New feature or request labels Feb 21, 2019
@malulleybovo
Copy link
Owner

This one turned out a bit more troublesome to fix. A potential fix was added, but I'm leaving it in the debug build only until I'm confident this did not produce side-effects.
You can try out the fix here:
https://malulleybovo.github.io/PSO2AffixingAssistant/index.debug.html

@FireswordMRM
Copy link

I am found some issue.
chrome_2019-02-25_00-03-42
After press confirm, fodder 0 always change with fodder with Astral and Ether, not a big issue
chrome_2019-02-25_00-03-55

Another one
Nothing happens after clicking confirm, work only if remove affixe by upslotting
chrome_2019-02-25_00-07-52
the result should be like here

@malulleybovo
Copy link
Owner

@FireswordMRM I have an idea of what is causing all that. However, could you create a new issue, add a title and maybe copy/paste what you said up there? That is all for issue tracking purposes. We will follow up on this issue there, thank you!

If you're new to this, you can open a new issue by going to https://github.com/malulleybovo/PSO2AffixingAssistant/issues/ and clicking on the green "New Issue" button towards the top right portion of the page. Then add a title and description to the issue.

malulleybovo added a commit that referenced this issue Feb 24, 2019
…n-transferables to Swap Into Complex Fodders

#4
- Last commit introduced this bug: f79f454
- When checking swaps to increase success rate, it could mistakably swap a non-transferable into a fodder containing other abilities, potentially making the fodder impossible to produce.
@malulleybovo
Copy link
Owner

malulleybovo commented Feb 25, 2019

After a fair bit of testing and bug spotting, I am now fairly confident the Assistant is treating Receptors how it is intended to. Non-transferable receptors still cannot be put together with "normal" abilities, but a select few combination of receptors can be put together (any combination between Soul Receptor, Gift Receptor, and Factor Receptor).

@malulleybovo malulleybovo reopened this Feb 27, 2019
malulleybovo added a commit that referenced this issue Feb 27, 2019
#4
- Stops using regex exclude pattern to handle receptors.
- Introduces ability pairing exceptions, which aims to add leeway for unconventional combinations of abilities as per the assistant's judgent.
- Now uses receptor detection + ability pair exceptions (such as Soul+Gift...) to handle receptors.
- Affix Selection view now does NOT list bilities that cannot be transferred for two reasons: uses cannot produce goals containing non-transferable abilities, and new receptor handling method judges putting non-transferables in goal as a conflict.
@malulleybovo
Copy link
Owner

Improvement on Receptor handling has been released. Feel free to reopen the issue if further problems related to this arise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants