Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chaining issue in openxr_load_properties() #10

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

keveleigh
Copy link
Contributor

Looking through this chain, it seems like it converges on .foveated_varjo from two directions:

  1. The normal chain from .system down, ending with a link from .foveated_varjo to .color_space_fb
  2. A chain from the bottom of this list, from .space_warp_fb up through to .foveated_varjo

.space_warp_fb doesn't appear to be chained to anything, so, as far as I can tell, this chain seems like it won't be passed into the xrGetSystemProperties call.

Please let me know if I'm reading this wrong or missing something! I don't have a headset with me that might resolve any of these, so I'm currently unable to test the actual resolution. I should be able to test on Tuesday though!

@maluoi
Copy link
Owner

maluoi commented Jun 13, 2022

Yeah, this is definitely a bug, thanks for catching this one! I did test this on a device, and was indeed seeing good results.

I think in the future I'll switch this over to this kind of pattern, which should hold up a lot better, less error prone:

result.hand_tracking.next = result.system.next; result.system.next = &result.hand_tracking;
result.hand_mesh    .next = result.system.next; result.system.next = &result.hand_mesh;

@maluoi maluoi merged commit 1c88d19 into maluoi:main Jun 13, 2022
@keveleigh keveleigh deleted the fix-chaining-issue branch May 3, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants