-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Builds continue after solver failures #2
Comments
yep, I noticed that too :) will fix it today |
raising a real RuntimeError now: https://github.com/TheSnakePit/boa/blob/6be7d4c7ef19e67a1e7aae2cf48be6a5280d0f8f/boa/cli/build.py#L191 with some nicely formatted error output. Thanks for testing! |
I think this has now broken builds with multiple outputs as it now errors saying the yet-to-be-built output doesn't exist. (The fix in #3 seems to have worked 👍) |
you're saying that master has another bug with multiple builds or that this broke a specific build for you because it's not continuing anymore? I tested builds with multiple outputs yesterday and it should be mostly fine... let me check again. |
Sorry, my fault for being excessively brief! I was building something like: outputs:
- name: A
- name: B
requirements:
run:
- A
- name: C
requirements:
run:
- A
- B
- name: D
requirements:
run:
- A
- B
- C which resulted in an error saying that A, B and C don't exist. Reverting 6be7d4c fixed the problem. I can make a reproducer recipe later today. |
I can't reproduce this to be honest. are you sure that there is not an issue in your recipe? |
When the solver fails a message is printed like below however the build continues regardless:
The text was updated successfully, but these errors were encountered: