-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ability to list conda-store environments #155
Added ability to list conda-store environments #155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just left a few comments on the README changes.
Bumps [tmpl](https://github.com/daaku/nodejs-tmpl) from 1.0.4 to 1.0.5. - [Release notes](https://github.com/daaku/nodejs-tmpl/releases) - [Commits](https://github.com/daaku/nodejs-tmpl/commits/v1.0.5) --- updated-dependencies: - dependency-name: tmpl dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
47a0fbf
to
2c1bbac
Compare
9cf66a9
to
6b9b1c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @peytondmurray
I'm surprised by the PR content as it contains far too much code duplication. For me the paradigm for conda-store should follow the one of conda environment; i.e. defining a model that provides the information through out the React components. This certainly implies changing the current model and components (for instance conda-store seems to support pagination). But code duplication should be avoided like plague in profit of a more generic and flexible API.
Let me know if you want to meet to discuss that.
I added some minor comments in the code too.
Thank you @fcollonval for the constructive feedback. Here's my plan going forward:
I'll update this thread when I have these prepared. Thanks again! |
Gentle ping @fcollonval can you take another look at the this PR and see if it is ready to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @peytondmurray sorry I was AFAK. I added a couple of questions/suggestions. But we are almost there.
ff1c720
to
9a318ff
Compare
9a318ff
to
8e890a8
Compare
@fcollonval Okay, this should be ready for another look. |
I'll do that tomorrow. I'm working to fix the CI. |
* Simplify binder build * Update postBuild * Add `jupyter-server` explicitly * Correct package name * Add missing requests * Skip pip check * Fix develop mode * More fix * Skip broken nbclassic * Back to Python 3.7 for non unix tests
@peytondmurray would you mind to rebase the PR on the latest master to restore the CI. Then if it passes, we are good to go. |
8e890a8
to
2b6f64d
Compare
Excellent, thanks for the help! I've rebased onto |
2b6f64d
to
0629e25
Compare
0629e25
to
7a94375
Compare
Thanks @peytondmurray merging now... |
Background info: conda-store
This PR adds initial support for conda-store, an environment management system which aims to provide reproducible conda environments in as many ways as possible to users and services. From the conda-store documentation:
Summary
This PR adds the ability to list conda-store environments from a new menu option. This PR is larger because this is foundational work for adding conda-store support; subsequent PRs will be smaller. Thanks for your patience with this!
Changes
Added
react-hooks
rules to.eslintrc.js
to help with react developmentIgnore
*.ipynb
in gitAdded documentation in
README.md
on setting up a development environment which watches frontend changes. Also added ayarn watch
script which automatically triggers a rebuild when a change in the frontend is detectedFixed an issue where the
NbConda
component would not reset itsisLoading
state if an operation was cancelledAdded new react components for handling conda-store operations and user interaction:NbCondaStore
CondaStorePkgPanel
CondaStorePkgList
CondaStoreEnvList
CondaStoreEnvItem
CondaStoreEnvWidget
Added a new model which supports conda-store through the existing UI components. This new model includes implementations of several key interfaces:
IEnvironmentManager
Conda.IPackageManager
To assist in troubleshooting conda-store server issues, I added a simple notification in case the conda-store server can't be reached when the package manager is first loaded.
The basis for additional functionality has also been added, following patterns currently existing for the
Conda
UI. However, functionality such as the ability to add additional environments has not yet been added; these functions will be filled in later.Disable automatic viewing of webpack-report.html when a build is complete.
Broke the conda-store integration off into its own package as per this comment
Modified
CondaPkgList
to add a React hook which can fetch packages as a user scrolls down through the package list. This allows for lazy loading of packages, and it works well with conda-store.@fcollonval If you get a chance to review this PR, I would be grateful for any feedback you have.