[MER][T11|T12|T13|T14] Creating the initial problems graph #1891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crogoz
commented
Aug 31, 2022
crogoz
commented
Aug 31, 2022
crogoz
commented
Aug 31, 2022
crogoz
changed the title
crogoz
changed the title
AntoinePrv
reviewed
Sep 5, 2022
Co-authored-by: Antoine Prouvost <AntoinePrv@users.noreply.github.com> Update libmamba/include/mamba/core/problems_graph_util.hpp Co-authored-by: Antoine Prouvost <AntoinePrv@users.noreply.github.com> Update libmamba/include/mamba/core/problems_graph_util.hpp Co-authored-by: Antoine Prouvost <AntoinePrv@users.noreply.github.com> Update libmamba/include/mamba/core/problems_graph_util.hpp Co-authored-by: Antoine Prouvost <AntoinePrv@users.noreply.github.com> Update libmamba/src/core/problems_graph_util.cpp Co-authored-by: Antoine Prouvost <AntoinePrv@users.noreply.github.com> Update libmamba/include/mamba/core/problems_graph_util.hpp Co-authored-by: Antoine Prouvost <AntoinePrv@users.noreply.github.com> Update libmamba/src/core/problems_graph_util.cpp Co-authored-by: Antoine Prouvost <AntoinePrv@users.noreply.github.com> Update libmamba/include/mamba/core/problems_graph_creator.hpp Co-authored-by: Antoine Prouvost <AntoinePrv@users.noreply.github.com> Update libmamba/src/core/problems_graph_util.cpp Co-authored-by: Antoine Prouvost <AntoinePrv@users.noreply.github.com> Update libmamba/include/mamba/core/problems_graph_util.hpp Co-authored-by: Antoine Prouvost <AntoinePrv@users.noreply.github.com>
crogoz
force-pushed
the
cr/problems-graph-creator
branch
from
5d1521a
to
39de2b4
Compare
|
I seems like the last failing test is due to a temporary connection error |
|
Awesome stuff. It all looks good to me (except for two changes that could be their own PR: in util_random.cpp and in subdirdata.cpp – both don't seem related to the core of this PR :) The other remark I had was that it could be nice to add more comments in the |
JohanMabille
requested changes
Oct 7, 2022
Merged
Few more fix from reviewers feedback
JohanMabille
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Graph creation implementation for #1878 (we only implemented the graph creation for a subset of the libsolv problems)
We create the graph using the libsolv problems list. We will only add the nodes in the graph if they haven't been added already. In order to check if a specific package is in the graph or not, we store a mapping between the SolveId (a unique identifier from libsolv) and Id (the unique node identifier for a node in the graph).
Because a solvable can appear in multiple libsolv problems, we might need to update the information for the node.
eg.