Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Direct dependency on fmt #2048

Merged
merged 9 commits into from
Oct 26, 2022
Merged

Direct dependency on fmt #2048

merged 9 commits into from
Oct 26, 2022

Conversation

AntoinePrv
Copy link
Member

@AntoinePrv AntoinePrv commented Oct 26, 2022 •
edited
Loading

Close #2044
Close #1694
Close #2047 (or revert #2047)
Close #2050

@AntoinePrv AntoinePrv mentioned this pull request Oct 26, 2022
Closed
@jonashaag jonashaag mentioned this pull request Oct 26, 2022
Closed
Klaim
Klaim approved these changes Oct 26, 2022
View reviewed changes
Copy link
Member

@Klaim Klaim left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏽

I wonder however if forcing the header-only target of fmt doesnt mean the users of libmamba (not mamba or micromamba) will end up having linking issues if they use the "normal" version of fmt.

@wolfv
Copy link
Member

wolfv commented Oct 26, 2022

Awesome!

@AntoinePrv
Copy link
Member Author

I wonder however if forcing the header-only target of fmt doesnt mean the users of libmamba (not mamba or micromamba) will end up having linking issues if they use the "normal" version of fmt.

@Klaim that segment should only apply to FULL_STATIC builds

@SylvainCorlay SylvainCorlay merged commit b8d7ec9 into mamba-org:main Oct 26, 2022
@AntoinePrv AntoinePrv deleted the fmt branch October 28, 2022 13:32
@bluescarni bluescarni mentioned this pull request Nov 3, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Klaim Klaim Klaim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spdlog and CMake Allow spdlog to be used with external fmt lib
4 participants
@AntoinePrv @wolfv @Klaim @SylvainCorlay