Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2248 #2249

Merged
merged 7 commits into from
Feb 3, 2023
Merged

Fix #2248 #2249

merged 7 commits into from
Feb 3, 2023

Conversation

jonashaag
Copy link
Collaborator

@jonashaag jonashaag commented Jan 25, 2023

Closes #2248

@jonashaag jonashaag mentioned this pull request Jan 25, 2023
2 tasks
@jonashaag
Copy link
Collaborator Author

Hm this is bad the test is supposed to fail

@wolfv
Copy link
Member

wolfv commented Jan 26, 2023

I think the conda version wasn't released on conda-forge yet, because of a conda-build bug.

@jonashaag
Copy link
Collaborator Author

@jonashaag
Copy link
Collaborator Author

@jonashaag jonashaag marked this pull request as ready for review January 26, 2023 09:33
@jonashaag
Copy link
Collaborator Author

Please squash merge

@jonashaag
Copy link
Collaborator Author

Hmm not sure what's going on

@jezdez
Copy link
Contributor

jezdez commented Jan 27, 2023

I think the conda version wasn't released on conda-forge yet, because of a conda-build bug.

Yeah, this is ongoing

@jonashaag
Copy link
Collaborator Author

That's good because we haven't fixed compatibility yet! :-D

@jonashaag
Copy link
Collaborator Author

Isn’t the last commit just another way to write exactly the same thing?

@wolfv
Copy link
Member

wolfv commented Feb 2, 2023

OK, I think I finally understand what's going on ... running mamba shell init probably overwrites what is written by micromamba in these files (e.g. stuff between # <<<<< mamba init <<<<). ugh. We should have used different delimiters from the start, too bad.

@jonashaag
Copy link
Collaborator Author

Another approach would’ve been to set $HOME to a temporary directory for the test.

@wolfv
Copy link
Member

wolfv commented Feb 3, 2023

yes, that's true and is also something we do in the micromamba tests. I'd be fine with merging and releasing this though :)

@wolfv wolfv merged commit 6baa36f into mamba-org:main Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

conda 23.1.0 breaks mamba init
3 participants