Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repoquery: Implemented recursive dependency printout. Closes: #1242 #2283

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

timostrunk
Copy link
Contributor

#1242 describes a way to get recursive dependency information from repoquery depends.

I implemented it as specified in the issue:

mamba repoquery depends cmake --recursive 

behaves exactly like

mamba repoquery depends cmake --tree

but lists the packages in a table. --tree overrides --recursive. Both mamba and micromamba have been updated. Please let me know if I should write additional tests and where.

@timostrunk
Copy link
Contributor Author

Thanks for starting the tests @wolfv Sorry for the broken pre-commit. Should pass now.

@timostrunk
Copy link
Contributor Author

I regenerated the stubs and reformatted them according to the pre-commit.

Copy link
Collaborator

@jonashaag jonashaag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

Do we want to mention the word "transitive" (vs. "recursive") or do you think that's too technical?

Do we have any tests for repoquery that should receive an addition?

@timostrunk
Copy link
Contributor Author

I think transitive fits much better than recursive. Should I adapt the pull request and change everything from recursive to transitive?

@jonashaag
Copy link
Collaborator

Although, "transitive" might be a less well known term. I'll let you make the decision.

@timostrunk
Copy link
Contributor Author

True, I added the explanation that --recursive means transitive to the helpstring and the docs.

Copy link
Collaborator

@jonashaag jonashaag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@jonashaag jonashaag merged commit 2fc0624 into mamba-org:main Feb 13, 2023
AntoinePrv pushed a commit to AntoinePrv/mamba that referenced this pull request Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants