Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove banner #2298

Merged
merged 5 commits into from
Jun 20, 2023
Merged

Remove banner #2298

merged 5 commits into from
Jun 20, 2023

Conversation

@JohanMabille
Copy link
Member

Shouldn't we fix the remaining bugs to guarantee that users can remove the banner if they want? Or even have it not displayed by default, but not entirely removed?

@jonashaag
Copy link
Collaborator Author

My take is that most users don't want the banner. Why would you want a banner?

@jonashaag
Copy link
Collaborator Author

@JohanMabille @AntoinePrv @Klaim @wolfv shall we remove the banners?

@AntoinePrv
Copy link
Member

I have no objection to removing the banner. I'm already removing it in my condarc.

@Klaim
Copy link
Member

Klaim commented Apr 3, 2023

I have no objection either.

@jonashaag jonashaag force-pushed the banner-rm branch 3 times, most recently from 2fd7f7e to a5bb46a Compare June 12, 2023 19:28
@jonashaag
Copy link
Collaborator Author

Hi all, I'm going to merge this this week if I don't hear any further feedback :)

@AntoinePrv
Copy link
Member

How about making the final call tomorrow (Tuesday June 20th 2023) during the mamba meeting?

@jonashaag
Copy link
Collaborator Author

I can't join tomorrow but feel free to make a decision :)

@JohanMabille
Copy link
Member

Sorry for the late reply, I have no objection to removing the banner.

@jonashaag jonashaag merged commit 0a7490c into mamba-org:main Jun 20, 2023
20 checks passed
@jonashaag jonashaag deleted the banner-rm branch June 20, 2023 14:53
@corneliusroemer
Copy link
Contributor

@jonashaag Just for clarification: Does this PR mean there's no more banner in any shape or form in neither mamba nor micromamba from 1.4.5 onwards? 🙏

I just spent 10 minutes figuring out how to remove the banner after switching to micromamba where my previous environment file solution didn't work anymore.

@jonashaag
Copy link
Collaborator Author

Yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants