Add checked numeric cast #2315
Merged
Add checked numeric cast #2315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfv
reviewed
Feb 22, 2023
| } | ||
| else | ||
| { | ||
| using float_type = std::common_type_t<From, To>; |
There was a problem hiding this comment.
Do we do a lot of casting between float types? Seems to me we should rather get rid of it if possible.
The integer ones are obviously necessary since libsolv uses 32 bit integers in quite some places.
There was a problem hiding this comment.
Do we do a lot of casting between float types? Seems to me we should rather get rid of it if possible.
I think I've seen a couple casting from integer to float but perhaps they need not be exact.
The integer ones are obviously necessary since libsolv uses 32 bit integers in quite some places.
Yes, even between signed and unsigned.
wolfv
approved these changes
Feb 22, 2023
Klaim
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a checked numeric cast to make checked conversion whenever we currently have a warning or a silencing
static_castwithout checks.