Clean util_string #2339
Merged
Clean util_string #2339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoinePrv
force-pushed
the
util-string
branch
3 times, most recently
from
337d7fd
to
031b380
Compare
|
Can be merged anytime to avoid conflicts, the rest can be merged in another PR. |
Hind-M
approved these changes
Mar 3, 2023
| @@ -290,7 +292,7 @@ namespace mamba | |||
| } | |||
|
|
|||
| LOG_DEBUG << "Currently running processes: " << get_all_running_processes_info(); | |||
| LOG_DEBUG << "Remaining args to run as command: " << join(" ", command); | |||
| fmt::print(LOG_DEBUG, "Remaining args to run as command: {}", fmt::join(command, " ")); | |||
There was a problem hiding this comment.
This is more a general question, but are we using fmt now everywhere for logging?
(btw, the LOG_DEBUG in the line above could be replaced as well)
There was a problem hiding this comment.
I think we can use fmt wherever we need it, here it avoids allocating the result of join.
JohanMabille
reviewed
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
util_stringheaderutil_string.cpputil.hppfromutil_string.hpp(lots of header changes related to this)AddDone in Add strip_if functions #2344strip_iffunction (needed for following PR)AddDone in Add split_once functions #2345split_oncefunctions (needed for following PR)Addsplit_for_eachas a replacement of split?