Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse repodata.json #2391

Merged
merged 7 commits into from
Mar 23, 2023
Merged

Parse repodata.json #2391

merged 7 commits into from
Mar 23, 2023

Conversation

AntoinePrv
Copy link
Member

@AntoinePrv AntoinePrv commented Mar 17, 2023 •
edited

For #2302

Parse repodata.json instead of relying on libsolv.

  • Add PackageRecord to reprensent repodata.json entries.
  • Add RepoData to match repodata.json schema
  • Add (integration) test on whole repodata.json.

To discuss:

  • What is the best way to keep repodata.json files for testing as they are quite large.
  • Do nlohmann::json work with rvlaue reference overloads? No

@AntoinePrv AntoinePrv marked this pull request as ready for review March 20, 2023 17:08
@AntoinePrv AntoinePrv self-assigned this Mar 20, 2023
JohanMabille
JohanMabille reviewed Mar 21, 2023
View reviewed changes
libmamba/include/mamba/specs/repo_data.hpp Show resolved Hide resolved
libmamba/include/mamba/specs/repo_data.hpp Outdated Show resolved Hide resolved
libmamba/include/mamba/specs/repo_data.hpp Outdated Show resolved Hide resolved
libmamba/include/mamba/specs/repo_data.hpp Outdated Show resolved Hide resolved
libmamba/include/mamba/specs/repo_data.hpp Outdated Show resolved Hide resolved
libmamba/include/mamba/specs/repo_data.hpp Outdated Show resolved Hide resolved
libmamba/include/mamba/specs/repo_data.hpp Outdated Show resolved Hide resolved
libmamba/include/mamba/specs/repo_data.hpp Outdated Show resolved Hide resolved
libmamba/include/mamba/specs/repo_data.hpp Outdated Show resolved Hide resolved
@AntoinePrv AntoinePrv force-pushed the specs-repodata branch 2 times, most recently from 8af0c7a to 6df1cb3 Compare March 22, 2023 14:21
@JohanMabille JohanMabille merged commit e169199 into mamba-org:main Mar 23, 2023
@AntoinePrv AntoinePrv deleted the specs-repodata branch March 24, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfv wolfv wolfv left review comments

@JohanMabille JohanMabille JohanMabille approved these changes

Assignees

@AntoinePrv AntoinePrv

Labels
type::general-improvement type::refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AntoinePrv @wolfv @JohanMabille