Refactor test_create, test_proxy, and test_env for test isolation #2416
Conversation
|
|
||
|
|
||
| def test_register_new_env(tmp_home, tmp_root_prefix): | ||
| helpers.create("-n", "env2", "--json", no_dry_run=True) |
There was a problem hiding this comment.
Do we remove the created test environments after the tests are done? It was handled by the teardown_class before... (This applies wherever create is used)
There was a problem hiding this comment.
This is handled by the tmp_root_prefix fixture that sets a temporary root prefix for all environments.
It is created under temporary storage, independent for each test, and safely cleaned up afterwards.
There was a problem hiding this comment.
Hmm yes, but it's not the case for the explicitly created envs env2, env3, etc. Is it?
There was a problem hiding this comment.
Oh ok I see, you mean that deleting the tmp_root_prefix deletes implicitely everything... ok!
There was a problem hiding this comment.
Yes exactly, the whole root_prefix is deleting, deleting everything with it
Big PR, sorry. Basically it uses the new fixture to create temporary root_prefix and home directory inside a /tmp folder.