Context structuring #2432
Context structuring #2432
Conversation
|
While I generally approve, I feel like the data being grouped are not "info" but "config(uration)". It's the configuration driving the library/program, it's not just various information or status. If I am correct, consider renaming? Hopefully it's not too hard to do using refactoring tools. |
Yeah there is a lot of it which is configuration, I used |
|
=> Params: can be from configuration or from the CLI or from anywhere, and it's more flexible regarding what we can move out of / to Configuration etc. |
|
Hmmm well maybe it's not too important and keeping it vague might be better for now... I'll let you decide. Now just "design" seems not clear to me, so maybe that needs to change - otherwise I'm approving this PR 👍🏽 |
The following commit to mamba mamba-org/mamba#2432 changes the way in which the context object is constructed. This means the next libmambapy version will break conda-libmamba-solver. Will be opening a PR on the fixes but the bigger question is how to preserve compatibility with older libmamba versions. We are going to have to continue with repodata patches potentially due to this? Hope this issue/PR opens a larger discussion. ```python ctx = libmambapy.context.Context() ctx.json # Attribute Error ctx.output_config.json # exists ``` This PR should not be merged since mamba with these changes has not been released yet.
* Upcoming changes in mamba context breaks conda-libmamba-solver The following commit to mamba mamba-org/mamba#2432 changes the way in which the context object is constructed. This means the next libmambapy version will break conda-libmamba-solver. Will be opening a PR on the fixes but the bigger question is how to preserve compatibility with older libmamba versions. We are going to have to continue with repodata patches potentially due to this? Hope this issue/PR opens a larger discussion. ```python ctx = libmambapy.context.Context() ctx.json # Attribute Error ctx.output_config.json # exists ``` This PR should not be merged since mamba with these changes has not been released yet. * add getattr safeguards ans group things together * pre-commit * add news [skip ci] --------- Co-authored-by: jaimergp <jaimergp@users.noreply.github.com>
This is a first pass on
Contextstructuring.I'm holding back any additional changes on this PR since it already involves many files (even if the changes are quite straightforward)...
If this is the way to go, work can be resumed on the
Contextentirely in another PR.