Remove dead code / attribute #2454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The idea of these was that we could bit-for-bit reconstruct the entry from repodata.json and compare the signature. Not all entries of repodata.json are necessarily parsed into libsolv. I think Adrien used to have a patched |
|
I think we can remove this code for now since it makes the refactoring more complicated, and reimplement it if/when we need it in the future. |
JohanMabille
approved these changes
Apr 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The keys
"solvable:extra_xxx"are not set in any place, and are never used in libsolv.Therefore that code is dead and
PackageInfo::extra_metadatais unused.