Add topological sort #2467
Merged
Add topological sort #2467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like #2472 is going well, so making this as ready. |
Hind-M
reviewed
Apr 19, 2023
Hind-M
approved these changes
Apr 19, 2023
Klaim
approved these changes
Apr 19, 2023
| const typename Graph::adjacency_list& adjacency | ||
| ) | ||
| { | ||
| status[start] = Visited::ongoing; |
There was a problem hiding this comment.
Is it safe to do this instead of using .at here?
There was a problem hiding this comment.
If it's required that start is in boundaries of status size, maybe just add an assertion?
There was a problem hiding this comment.
@Klaim This is a private function, but it is true that the input is not checked from the caller (dfs_raw).
That being said, node_ids are passed from the user all over the class without being checked. Should we fix that, or is that a contract?
I'm adding a couple of assert where you specified.
There was a problem hiding this comment.
I think that's a contract of the functions and the asserts are enough checks yeah.
Hind-M
reviewed
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_reachablesignaturedepth_first_searcha free function to mirror networkx, rename itdfs_