Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mamba version to mamba info output #2477

Merged
merged 3 commits into from
Apr 21, 2023
Merged

Add mamba version to mamba info output #2477

merged 3 commits into from
Apr 21, 2023

Conversation

Hind-M
Copy link
Member

@Hind-M Hind-M commented Apr 20, 2023

Fix #2458

AntoinePrv
AntoinePrv approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@AntoinePrv AntoinePrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not knowledgeable with this code, but I assume you checked the output.
Best case would be to add a simple sanity test in mamba/tests.

mamba/mamba/mamba.py Outdated Show resolved Hide resolved
@AntoinePrv AntoinePrv merged commit 5a01488 into mamba-org:main Apr 21, 2023
20 checks passed
@Hind-M Hind-M deleted the mamba_info branch April 24, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Klaim Klaim Klaim approved these changes

@JohanMabille JohanMabille JohanMabille approved these changes

@AntoinePrv AntoinePrv AntoinePrv approved these changes

@jonashaag jonashaag Awaiting requested review from jonashaag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mamba info seems to not include the Mamba version
4 participants
@Hind-M @Klaim @JohanMabille @AntoinePrv