Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set log_level to critical with --json option #2484

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

Hind-M
Copy link
Member

@Hind-M Hind-M commented Apr 24, 2023

Fix #2446
I don't know the reason behind setting log_level to off when dealing with --json but I guess it shouldn't be the case.
Let's see if the CI tests fail...

@jonashaag
Copy link
Collaborator

Is it because the log output is incorrectly sent to stdout and this was a workaround? JSON output should go to stdout and errors to stderr

@Hind-M
Copy link
Member Author

Hind-M commented Apr 25, 2023

Yeah, most certainly...

@JohanMabille JohanMabille merged commit de6b746 into mamba-org:main Apr 26, 2023
20 checks passed
@jonashaag
Copy link
Collaborator

Are we now sending logs and JSON output to stdout?

@Hind-M
Copy link
Member Author

Hind-M commented Apr 26, 2023

We are planning to completely rework the logging system of mamba by the end of this year, but since it's still some way off, bugs should be fixed meanwhile.
In this fix, critical errors will be shown in the case of json as well. But I believe we are not changing anything else.
(If there are any critical errors, I don't think json output would be relevant anyway...)
Note that when fixing #2458, I noticed that json output is sent to stdout because we use conda which is again showing the inconsistencies when handling all this logging...

@Hind-M Hind-M deleted the umamba_json branch April 26, 2023 09:13
AntoinePrv pushed a commit to AntoinePrv/mamba that referenced this pull request May 3, 2023
Set log_level to critical with json option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

micromamba install --json with a bad channel results in no output
3 participants