Add VersionSpec #2502
Merged
Add VersionSpec #2502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
AntoinePrv
commented
Apr 27, 2023
•
AntoinePrv
commented
- Based on Add boolean expression tree #2591
AntoinePrv
force-pushed
the
specs-version-specs
branch
from
0058681
to
489d699
Compare
AntoinePrv
force-pushed
the
specs-version-specs
branch
3 times, most recently
from
0aadbe0
to
16256ff
Compare
AntoinePrv
commented
Jul 5, 2023
Comment on lines
+437
to
+445
| if (b.local().empty()) | ||
| { | ||
| return starts_with_three_way(a.version(), b.version()); | ||
| } | ||
| if (auto c = compare_three_way(a.version(), b.version()); c != strong_ordering::equal) | ||
| { | ||
| return c; | ||
| } | ||
| return compare_three_way(a.local(), b.local()); | ||
| return starts_with_three_way(a.local(), b.local()); |
AntoinePrv
force-pushed
the
specs-version-specs
branch
from
ba40dd6
to
8d06ccf
Compare
AntoinePrv
requested review from
JohanMabille and
Klaim
and removed request for
JohanMabille
AntoinePrv
force-pushed
the
specs-version-specs
branch
from
8d06ccf
to
b65a845
Compare
JohanMabille
approved these changes
Jul 20, 2023
Klaim
approved these changes
Jul 20, 2023
cvanelteren
pushed a commit
to cvanelteren/mamba
that referenced
this pull request
Jul 31, 2023
* Add specs::Version default ctor * Add spec::VersionInterval * Add VersionSpec * Add starts_with char overloads * Partial VersionSpec::parse * Improve layout * Remove merge conflict * Add empty version constructor test * Add missing headers * Rewrite VersionSpec in term of VersionPredicate * Handle empty expressions in Postfix and Infix parsers * Add tests and fix to VersionSpec::parse * Add util_string is_punct * Add VersionPredicate::not_starts_with * Fix Version::starts_with * Refactor VersionSpec::parse to better handle globs * Add Version and VersionSpec litterals * Fix '*' and '~=1.1' cases in VersionSpec::parse * Refactor VersionSpec tests and add conda tests * Fix std::max overload on MSVC
cvanelteren
pushed a commit
to cvanelteren/mamba
that referenced
this pull request
Aug 29, 2023
* Add specs::Version default ctor * Add spec::VersionInterval * Add VersionSpec * Add starts_with char overloads * Partial VersionSpec::parse * Improve layout * Remove merge conflict * Add empty version constructor test * Add missing headers * Rewrite VersionSpec in term of VersionPredicate * Handle empty expressions in Postfix and Infix parsers * Add tests and fix to VersionSpec::parse * Add util_string is_punct * Add VersionPredicate::not_starts_with * Fix Version::starts_with * Refactor VersionSpec::parse to better handle globs * Add Version and VersionSpec litterals * Fix '*' and '~=1.1' cases in VersionSpec::parse * Refactor VersionSpec tests and add conda tests * Fix std::max overload on MSVC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.