Reset fish shell status even if variable not exists #2509
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is pretty straightforward, where it avoids polluting shell status with status code
> 0
.Currently all the following functions
activate
,deactivate
,reactivate
,install
, ... return non-zero status for me due to the variable setting in functions likewill return non-zero status if those variables do not exists.
Note1:
set -e XXX
can't erase non-existing variable, and will return non-zero status if that happens.Note2: setting variable (e.g.
set -gx CONDA_SHLVL "0"
) does not modify the current return status, so it doesn't reset the fail status from attempting to erase non-existing variables.This just modify the erasing command into something like: