-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use only vcpkg for static windows build #2520
Conversation
Thanks a lot for working on this! I wonder if there is a way to share the build instructions with the feedstock. Maybe we can use the feedstock |
The dependencies on conda-forge are not maintained by mamba-org devs only.
Which means we would not be able to catch conda build errors before trying to build the feedstock. I agree that reducing the build time for windows static build is more than required; however we should definitely have an automatic way to test micromamba feedstock at least before releasing. Maybe a pre-release branch with the feedstock build triggered on it would be an acceptable solution. On the long run, the goal would be to have all the static dependencies correctly packaged on conda-forge so that we can have a full static build without needing vcpkg at all (but that's another story). |
Seems reasonable to me 👍🏻 |
@JohanMabille should we merge this now then? |
@pavelzw sorry for this super late answer, your notification was drowned in the mass and the last weeks were quite intense. Happy that this was merge! |
No worries 👍🏻 |
I suggest we switch to vcpkg completely for the windows static build process for micromamba. This makes the build pipeline for windows more maintainable since the dependencies in vcpkg are actively maintained not only by mamba-org. Also, fewer weird errors occur when building outside of a conda environment with MSVC.
This also allows us to use
windows-latest
instead ofwindows-2019
.The build time for static win-64 sinks from 40min down to 7min or 2min with sccache (as long as the vcpkg dependencies are cached which is now easier outside of a conda env).