[Internal] Use subsub commands for micromamba shell
#2527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoinePrv
changed the title
micromamba shellmicromamba shell
AntoinePrv
force-pushed
the
cli-shell
branch
2 times, most recently
from
6922b41
to
82aafe0
Compare
Hind-M
reviewed
May 19, 2023
| @@ -58,7 +58,7 @@ function Exit-MambaEnvironment { | |||
| if ($deactivateCommand.Trim().Length -eq 0) { | |||
| return; | |||
| } | |||
| Write-Verbose "[micromamba shell deactivate -s powershell]`n$deactivateCommand"; | |||
| Write-Verbose "[micromamba shell deactivate --shell powershell]`n$deactivateCommand"; | |||
There was a problem hiding this comment.
Is this change aiming to make the command more explicit?
If so, should we change it everywhere?
There was a problem hiding this comment.
Yhea, it's cosmetic. At first I started looking at them because I wanted to remove usages of micromamba shell --shell in favor of micromamba shell --shell `
Hind-M
approved these changes
May 22, 2023
Klaim
approved these changes
May 22, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was previously not using sub command, which creates a mix of invlaid CLI arguments.
This is taking some load off #2475.