Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix umamba tests ¯\_(ツ)_/¯ #2540

Merged
merged 1 commit into from
May 23, 2023
Merged

Fix umamba tests ¯\_(ツ)_/¯ #2540

merged 1 commit into from
May 23, 2023

Conversation

AntoinePrv
Copy link
Member

This test is failing on main and this seems to fix it, but I have no idea what was expected with the == 2.

@jonashaag
Copy link
Collaborator

Was it python and python_abi or something like that?

@wolfv
Copy link
Member

wolfv commented May 23, 2023

I think the test was that requests and six are relinked when upgrading the python version. Seems like there is one more noarch package in the tree now?

@AntoinePrv
Copy link
Member Author

AntoinePrv commented May 23, 2023

Was it python and python_abi or something like that?

That's my guess too.

I think the test was that requests and six are relinked when upgrading the python version.

The assertion is the number of output of micromamba list python after micromamba install python requests six. No update yet.

Seems like there is one more noarch package in the tree now?

One less? The count is 1 but I used >= in case it jumps back to 2.
Edit: see second answer.

@Klaim
Copy link
Member

Klaim commented May 23, 2023

That test feels fragile as it rely on a package that we have no control over the dependencies of?

Copy link
Member

@Klaim Klaim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

>= 1 seems decent (as long as the package doesnt decide to remove all dependencies..)

@AntoinePrv AntoinePrv merged commit 02a539d into mamba-org:main May 23, 2023
20 checks passed
@AntoinePrv AntoinePrv deleted the ci branch May 23, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants