Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try new vcpkg #2572

Merged
merged 11 commits into from
Jun 12, 2023
Merged

Try new vcpkg #2572

merged 11 commits into from
Jun 12, 2023

Conversation

AntoinePrv
Copy link
Member

No description provided.

@JohanMabille JohanMabille merged commit 338bdd4 into mamba-org:main Jun 12, 2023
19 of 20 checks passed
@jonashaag
Copy link
Collaborator

Thanks for this!

Any reason not to use the more fine grained caching? Like here:

- name: Cache vcpkg packages
uses: actions/cache@v3
with:
# The installed packages are in %VCPKG_INSTALLATION_ROOT%\installed\x64-windows-static
# and the info which packages are installed is in %VCPKG_INSTALLATION_ROOT%\installed\vcpkg
path: C:\Users\runneradmin\AppData\Local\vcpkg
key: vcpkg-win-64-appdata

@AntoinePrv AntoinePrv deleted the ci branch June 13, 2023 08:40
@AntoinePrv
Copy link
Member Author

@jonashaag I'm no VCPKG expert, so I went for a greedy approach.
For the line you point too, I'm also wondering if the cache is working as intended (need to investigate).

@pavelzw
Copy link
Member

pavelzw commented Jun 13, 2023

When I added it, it worked 😅 I'm also curious why the builds took so long the last time... The appdata cache was 3 weeks old, maybe this played a role; we should add some kind of cache invalidation for this (as is done here).

@pavelzw
Copy link
Member

pavelzw commented Jun 13, 2023

@jonashaag deleted the 3 week old cache an hour ago, it got rebuilt in the latest master push and is now working correctly in the latest push of #2585. So adding the week to the cache should fix the issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants