Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[micromamba] [mamba] Fix wrong download url for custom channels #2596

Merged
merged 5 commits into from
Jun 16, 2023

Conversation

Hind-M
Copy link
Member

@Hind-M Hind-M commented Jun 15, 2023

@Hind-M Hind-M self-assigned this Jun 15, 2023
Copy link
Member

@AntoinePrv AntoinePrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left a few more nitpicking suggestions if you think they are valuable.

libmamba/tests/src/core/test_util_string.cpp Outdated Show resolved Hide resolved
libmamba/src/core/util_string.cpp Outdated Show resolved Hide resolved
libmamba/src/core/util_string.cpp Outdated Show resolved Hide resolved
Rename get_common_substr to get_common_parts
Add constraints to avoid irrelevant substrings in common parts
Add sep argument
Add tests
@JohanMabille JohanMabille merged commit 12f100c into mamba-org:main Jun 16, 2023
20 checks passed
@Hind-M Hind-M deleted the custom_channels_urls branch June 16, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong download url for custom channels with labels
3 participants