Fix add missing pip PREREQ_MARKER #2612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfv
reviewed
Jun 21, 2023
| const_cast<::Solvable*>(raw()), | ||
| SOLVABLE_PROVIDES, | ||
| q.raw(), | ||
| /* marker= */ -1 |
There was a problem hiding this comment.
Do we know why we need this magic number here?
There was a problem hiding this comment.
This was only reformated by I believe this magic number was already present pre-refactoring.
The idea is that dep array can be split in to with a magic marker. When retrieving the dependencies, -1 means first part, 1 means second and 0 means everything, including said marker (which is not a valid dependency).
That works if the default maker was used when setting the dependencies...
So yes, a bit of a mess.
See also the test case added in this PR. So far we have no need for markers in provide key so we keep sane defaults.
JohanMabille
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug introduced in #2453
Close #2546