Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with older Clang #2625

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Conversation

pavelzw
Copy link
Member

@pavelzw pavelzw commented Jun 27, 2023

See #2397

  /tmp/micromamba-20230627-77271-10613rh/mamba-micromamba-1.4.5/libmamba/src/solv-cpp/pool.cpp:135:27: error: chosen constructor is explicit in copy-initialization
          std::stringstream msg = {};
                            ^     ~~
  /Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk/usr/include/c++/v1/sstream:884:14: note: explicit constructor declared here
      explicit basic_stringstream(ios_base::openmode __wch = ios_base::in | ios_base::out);
               ^
  1 error generated.
  make[2]: *** [libmamba/CMakeFiles/libmamba.dir/src/solv-cpp/pool.cpp.o] Error 1

Occurred in Homebrew/homebrew-core#135110

@jonashaag
Copy link
Collaborator

@pavelzw is the build failure related?

@jonashaag jonashaag enabled auto-merge (squash) June 27, 2023 13:12
@jonashaag jonashaag merged commit 2209a90 into mamba-org:main Jun 27, 2023
19 of 20 checks passed
@pavelzw pavelzw deleted the stringstream-copy-init branch June 27, 2023 13:15
@pavelzw
Copy link
Member Author

pavelzw commented Jun 27, 2023

is the build failure related

No, it fails during a VCPKG step before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants