Use xdg schemas for config saving/reading (minified) #2714
Conversation
| } | ||
|
|
||
| std::vector<fs::u8path> mamba_user = { | ||
| env::user_config_dir() / ".mambarc", env::user_config_dir() / "mambarc", |
| if (maybe_user_config_dir.empty()) | ||
| { | ||
| #ifdef _WIN32 | ||
| maybe_user_config_dir = ::mamba::win::get_folder("roamingappdata"); |
There was a problem hiding this comment.
@pavelzw see discussion in the other PR. I'm fine with the decision to use this as the Windows default folder; people can always set the XDG vars.
There was a problem hiding this comment.
On Cygwin I'd be surprised if ~/.config wasn't read by default though...
There was a problem hiding this comment.
I'm also fine with this. If people want to have XDG like stuff on cygwin, they should just set it in their bashrc/bash_profile.
|
Sorry, I forgot to look at this. I'll do it today 😅 |
| } | ||
|
|
||
| std::vector<fs::u8path> mamba_user = { | ||
| env::user_config_dir() / ".mambarc", env::user_config_dir() / "mambarc", |
There was a problem hiding this comment.
I think actually @0xbe7a uses them 😄 so yes
| if (maybe_user_config_dir.empty()) | ||
| { | ||
| #ifdef _WIN32 | ||
| maybe_user_config_dir = ::mamba::win::get_folder("roamingappdata"); |
There was a problem hiding this comment.
I'm also fine with this. If people want to have XDG like stuff on cygwin, they should just set it in their bashrc/bash_profile.
I personally agree! |
|
🎉 |
Co-authored-by: Danny Farrell <dan@cyrusbio.com>
|
@danpf Interestingly for me this doesn't work if I don't create an empty |
|
@jonashaag It looks like the code has been significantly refactored since this was merged. Although my long comment is still there, (seems like it should be deleted now) it looks like someone expanded the config/environment. So I don't think you should still see the |
|
Not sure what you are referring to. Your tests still seem to be there. So if the tests used to worked we should have realized if something broke. I'll try to investigate. |
|
Sorry, now I understand where the changes are coming from: #2983 |
This is a 'mini' version of #1836
I tried not to rock the boat too much with this one.
This PR added some helper functions in order to support the xdg directory schema, as well as pollute the users home directory less.
Fixes: #1787
Maybe I shouldn't have, but it felt weird intercalating the mamba and conda configs, so i separated them and just made all mamba configs superseed the conda configs.
as an aside, (sorry for the un-requested opinion), I totally understand what this org is doing, but I think trying to act as a drop in replacement for conda while at the same time building out its own configs (mambarc etc) is very confusing. I think it should just be one or the other. Or at least only condarc etc until the project is mature enough, and then switch to mambarc after a major version bump when it's ready.