Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warnings from test_activation #2727

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

AntoinePrv
Copy link
Member

No description provided.

@AntoinePrv AntoinePrv self-assigned this Aug 2, 2023
tmp_root_prefix,
tmp_path,
interpreter,
def env_to_dict(out, interpreter="bash"):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All this diff is from making the tests not class method.
I think this is better so there is not temptation to use class attributes.

@AntoinePrv AntoinePrv requested a review from Hind-M August 3, 2023 06:46
Copy link
Member

@Hind-M Hind-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay! And what were the warnings about?

@AntoinePrv
Copy link
Member Author

Linter warnings such as "reference to <...> may be undefined" because of the from helpers import *.

@AntoinePrv AntoinePrv merged commit 0c51541 into mamba-org:main Aug 3, 2023
20 checks passed
@AntoinePrv AntoinePrv deleted the test-activation branch August 3, 2023 08:48
cvanelteren pushed a commit to cvanelteren/mamba that referenced this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants