fix subcommands handling in recent versions of conda #2732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
jonashaag
approved these changes
Aug 3, 2023
Co-authored-by: Jonas Haag <jonas@lophus.org>
|
When will this be merged? |
|
Thanks @jonashaag! Would be great if this was released soon. I think @JohanMabille is the man for this :) |
5 tasks
cvanelteren
pushed a commit
to cvanelteren/mamba
that referenced
this pull request
Aug 29, 2023
Co-authored-by: Jonas Haag <jonas@lophus.org>
wence-
added a commit
to wence-/cudf
that referenced
this pull request
Sep 8, 2023
Since Conda 23.7.3, the plugin mechanism changed, and mambabuild broke. Adapt to this change, following the fix in mamba (mamba-org/mamba#2732)
This was referenced Sep 8, 2023
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Sep 8, 2023
Since Conda 23.7.3, the plugin mechanism changed, and mambabuild broke. Since, with `boa` installed, `conda mambabuild` uses the `libmamba` solver, switch to that. The general handling of subcommands with `mamba` was partially fixed in mamba-org/mamba#2732, but `mamba build` does not currently work due to mamba-org/mamba#2821. - Closes #14068 Authors: - Lawrence Mitchell (https://github.com/wence-) Approvers: - Ray Douglass (https://github.com/raydouglass) URL: #14067
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2715
I guess users were expecting
mamba buildto work, but it was basically by chance I'd say (conda would happen to findconda_buildinbin/). Now that the subcommands use a plugin system, we can't just rely on the existence of binaries, and need to forward the calls manually.In this PR:
mamba envtomamba.mamba_envmamba buildtoboa.cli.mambabuild