Bring back repodata_use_zst #2790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoinePrv
reviewed
Aug 31, 2023
| && m_metadata.has_zst.value().has_expired(); | ||
| bool has_zst = m_metadata.check_zst(channel_context, p_channel); | ||
| if (!has_zst && (is_expired || !has_value)) | ||
| if (ctx.repodata_use_zst) |
There was a problem hiding this comment.
No else clause? What happens when we deactivate it?
There was a problem hiding this comment.
Consider this the same case as !has_zst && !is_expired && has_value) in the old code. No zst checking is done. Not sure exactly how the code that runs after this works, but if I'm not mistaken it should not change behaviour.
AntoinePrv
force-pushed
the
repodata-use-zst
branch
from
d09f428
to
d3c66a7
Compare
AntoinePrv
approved these changes
Sep 1, 2023
JohanMabille
approved these changes
Sep 1, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some enterprise Conda channel sources like Artifactory don't properly invalidate the
repodata.json.zst. This adds back the flag to disable reading thezstfile