Parse subdirs in CLI match specs #2799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonashaag
commented
Aug 29, 2023
| platform | ||
| ); | ||
| if (!platform.empty()) | ||
| { | ||
| platforms.push_back(std::move(platform)); | ||
| value = cleaned_url; |
There was a problem hiding this comment.
I changed this because I think we always want the rstrip() from split_platform. Or we should make that rstrip() conditional on if we found a platform.
There was a problem hiding this comment.
I think all usecases should be consistent, so let's rstrip all the time.
Fixes mamba-org#2792 For example, the channel in `install conda-forge/noarch::tzdata` would previously be parsed as `conda-forge/noarch` while it should be parsed as `conda-forge` with `noarch` subdir.
JohanMabille
approved these changes
Aug 31, 2023
| platform | ||
| ); | ||
| if (!platform.empty()) | ||
| { | ||
| platforms.push_back(std::move(platform)); | ||
| value = cleaned_url; |
There was a problem hiding this comment.
I think all usecases should be consistent, so let's rstrip all the time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2798 without the interface changes.
Fixes #2792
For example, the channel in
install conda-forge/noarch::tzdatawould previously be parsed asconda-forge/noarchwhile it should be parsed asconda-forgewithnoarchsubdir.