added support for empty lines in dependency file in txt format. micro… #2812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mamba was crashing earlier Change-Id: I162cf8837591bca8221a504450e35008df2c501f
|
Thank you! Please add a test. |
Change-Id: I3b32cc558aa8ef7ed38872db2db128123d05ad4d
jonashaag
previously approved these changes
Sep 7, 2023
Change-Id: I3cc0d450bdeef541717995ee7162b5765aa6adfc
Change-Id: I31ae7bd1c9d06d7f25f0e601ea60de2c035b4d3d
|
Are we using the |
|
No, we are not using it. I will remove them
…On Fri, 8 Sep 2023 at 7:44 PM, Jonas Haag ***@***.***> wrote:
Are we using the env_*.txt files anywhere?
—
Reply to this email directly, view it on GitHub
<#2812 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BAHQ6NU62NGVBLXMXEG7WUTXZMR3VANCNFSM6AAAAAA4M26KIA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Change-Id: I428bcc6461173a8f23e3b1c1b4e8137990d37a12
|
@jonashaag can u please approve , since all checks are passing |
JohanMabille
approved these changes
Sep 13, 2023
|
Thanks! |
|
Nice, thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mamba was crashing earlier
fixes #2372
Change-Id: I162cf8837591bca8221a504450e35008df2c501f