Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix stubs #2817

Merged
merged 3 commits into from
Sep 7, 2023
Merged

fix stubs #2817

merged 3 commits into from
Sep 7, 2023

Conversation

AntoinePrv
Copy link
Member

@AntoinePrv AntoinePrv commented Sep 6, 2023

Context:

  • pybind11-stubgen is not that stable. There is a release for both 1.0 and 2.0 in the last week.
  • pybind11-stubgen>=1.0 emits code that is Python3.9+ (like list[T], int | None) with no apparent way to control it.
  • compare_stubs.py does not seem to work with any version >=1.0
  • All versions emit invalid python code: class A(B) before class B is defined.

What changed:

@JohanMabille JohanMabille merged commit 69a2cd3 into mamba-org:main Sep 7, 2023
17 checks passed
@AntoinePrv AntoinePrv deleted the fix-stubs branch September 7, 2023 08:12
JohanMabille pushed a commit that referenced this pull request Oct 16, 2023
* Downpin pybind11-stubgen

* Fix stubgens

* Regenerate stubs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants