Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatibility fixes for conda 23.9 and conda-libmamba-solver 23.9 #2878

Merged
merged 5 commits into from
Oct 2, 2023

Conversation

jaimergp
Copy link
Contributor

There have been some changes that break mamba's CLI:

  • conda has deprecated ensure_name_or_prefix. We do that manually now.
  • conda does not take context as an argument in init_loggers anymore.
  • conda-libmamba-solver exposes the same repoquery subcommand through the subcommand plugin system, which causes a conflict in Python 3.11. Interestingly only in that version.

@JohanMabille
Copy link
Member

JohanMabille commented Oct 2, 2023

We should probably also add a lower bound to the conda dependency inthe environment dev file

@JohanMabille
Copy link
Member

Also we may want to backport this fix to a 1.x branch; with all recent API breaking changes, next release of mamba will be 2.0 and is not planned for soon.

@JohanMabille JohanMabille merged commit e0d4f6d into mamba-org:main Oct 2, 2023
17 checks passed
@JohanMabille
Copy link
Member

Thanks!

@AntoinePrv AntoinePrv mentioned this pull request Oct 3, 2023
@jaimergp
Copy link
Contributor Author

jaimergp commented Oct 3, 2023

Also we may want to backport this fix to a 1.x branch; with all recent API breaking changes, next release of mamba will be 2.0 and is not planned for soon.

Let me know once such a branch is available. I'll be happy to backport! @JohanMabille

@JohanMabille
Copy link
Member

@jaimergp thanks! Here you go: https://github.com/mamba-org/mamba/tree/1.x

@jaimergp
Copy link
Contributor Author

jaimergp commented Oct 4, 2023

@JohanMabille 🚀 -> #2890

JohanMabille pushed a commit that referenced this pull request Oct 4, 2023
…-solver 23.9 (#2890)

* trim

* pre-commit

* raise

* require conda 23.9.0+
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants