Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mamba #2942

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Remove mamba #2942

merged 1 commit into from
Oct 30, 2023

Conversation

AntoinePrv
Copy link
Member

@AntoinePrv AntoinePrv commented Oct 27, 2023

Mamba python code is no longer needed:

  • conda-libmamba-solver uses libmambapy;
  • boa now uses libmambapy.

Are we missing anything? All projects are strongly encouraged to move to full libmambapy.

👀 @isuruf @jonashaag @jaimergp @jezdez @Hind-M @Klaim @JohanMabille @wolfv

@jaimergp
Copy link
Contributor

I think there's some conda-forge infra that uses mamba, but maybe it also imports libmambapy directly. Let me check!

@AntoinePrv
Copy link
Member Author

More context:

  • existing mamba package will continue to exists;
  • there is a 1.x branch for bug fixes;
  • but we consider that this is too much legacy to take to 2.0.

@jaimergp
Copy link
Contributor

Yeah, the check-solvables component in conda-forge uses utils.load_channels(): https://github.com/regro/conda-forge-feedstock-check-solvable/blob/fa9b0500c09e39e9e3c228fd4f82a1a769079200/conda_forge_feedstock_check_solvable/mamba_solver.py#L39

This github search reveals some other users, like some asv plugin or bioconda infra.

I think those are workable, but maybe some folks would like to have some utilities in the libmambapy namespace, like libmambapy.utils or something?

@AntoinePrv
Copy link
Member Author

In an ideal world we'd gave both a high and low level API. The low does nothing smart, purely, functional, and could be written to make another type of package manager (à la pixi). The high-level is a do conda things (such as load_channels) sort of API, that would be the building steps of micromamba.

@jaimergp for Conda-Forge's load_channels, I would advice copying that function into the code where it is used for now. This is what I did for boa.

@AntoinePrv
Copy link
Member Author

@jaimergp can you confirm that we can merge this and that porting the remaining code to other project is a good option for you.
For everyone else, I take the lack of answer as a lack of objection.

@jaimergp
Copy link
Contributor

Yep, no probs at all! Go ahead!

@JohanMabille
Copy link
Member

Farewell little python code, you did a great job but now your time has passed

@JohanMabille JohanMabille merged commit c32da69 into mamba-org:main Oct 30, 2023
18 checks passed
@SylvainCorlay
Copy link
Member

I love how we just merged a PR named "remove mamba" into mamba.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants