Migrate Channel::make_channel to resolve multi channels #2986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
AntoinePrv
commented
Nov 16, 2023
AntoinePrv
commented
- Add one to many get_channels
- Refactor ChannelContext params
- ChannelContext::make_channel migration 1
AntoinePrv
force-pushed
the
channel-resolve
branch
7 times, most recently
from
2e36559
to
f0e721c
Compare
AntoinePrv
changed the title
| platform_urls(bool with_credential = true) const; | ||
| util::flat_set<std::string> urls(bool with_credential = true) const; | ||
| [[nodiscard]] auto platform_urls(bool with_credential = true) const | ||
| -> util::flat_set<std::pair<std::string, std::string>>; |
There was a problem hiding this comment.
The return type deserves a typename
There was a problem hiding this comment.
This part still needs improvement overall, such as not converting URL to strings.
However, I will first rework the tests, since it is heavily (and unnecessarily anymore) used there.
AntoinePrv
force-pushed
the
channel-resolve
branch
from
72ebf2f
to
3a6af4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.