Bind Channel #3001
Merged
Bind Channel #3001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoinePrv
force-pushed
the
channel-bind
branch
6 times, most recently
from
ab45c5a
to
13afd8f
Compare
| @@ -35,7 +35,7 @@ namespace mamba::specs | |||
| explicit CondaURL(util::URL&& url); | |||
| explicit CondaURL(const util::URL& url); | |||
|
|
|||
| auto base() const -> const util::URL&; | |||
| [[nodiscard]] auto generic() const -> const util::URL&; | |||
There was a problem hiding this comment.
I find base more meaningful
There was a problem hiding this comment.
The fact the it the base is not relevant here. What matters is that there is a generic alternative to this class to which we can convert.
AntoinePrv
force-pushed
the
channel-bind
branch
from
7e243be
to
a17f3bc
Compare
JohanMabille
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.