Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore use_default_signal_handler flag for libmambapy #3028

Merged

Conversation

dholth
Copy link
Contributor

@dholth dholth commented Dec 1, 2023

This was present in the 1.5.x libmambapy but was probably lost in the mamba refactor. It allows CTRL-C to work in Python, instead of being disabled as a side effect of merely importing libmambapy.

Fix #3019

@AntoinePrv AntoinePrv force-pushed the 3019-disable-signal-handler-python branch from 457bd39 to 98dcca3 Compare December 7, 2023 14:59
@AntoinePrv
Copy link
Member

Thanks !

@dholth
Copy link
Contributor Author

dholth commented Dec 7, 2023

@jaimergp this leaves out some things compared to https://github.com/mamba-org/mamba/pull/3018/files

I still need to test this manually by pressing CTRL-C.

@AntoinePrv AntoinePrv added this pull request to the merge queue Dec 7, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 7, 2023
@AntoinePrv AntoinePrv merged commit d12d770 into mamba-org:main Dec 7, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preserve Context::use_default_signal_handler(bool val) and binding in refactor
2 participants