restore use_default_signal_handler flag for libmambapy #3028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoinePrv
approved these changes
Dec 7, 2023
AntoinePrv
force-pushed
the
3019-disable-signal-handler-python
branch
from
457bd39
to
98dcca3
Compare
|
Thanks ! |
|
@jaimergp this leaves out some things compared to https://github.com/mamba-org/mamba/pull/3018/files I still need to test this manually by pressing CTRL-C. |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was present in the 1.5.x libmambapy but was probably lost in the mamba refactor. It allows CTRL-C to work in Python, instead of being disabled as a side effect of merely importing libmambapy.
Fix #3019