Bind ChannelContext #3034
Merged
Bind ChannelContext #3034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
AntoinePrv
commented
Dec 5, 2023
AntoinePrv
commented
- Bind ChannelContext
- Deprecate Context() in Python
AntoinePrv
commented
Dec 5, 2023
| @@ -696,10 +696,42 @@ bind_submodule_impl(pybind11::module_ m) | |||
| .value("CRITICAL", mamba::log_level::critical) | |||
| .value("OFF", mamba::log_level::off); | |||
|
|
|||
| py::class_<ChannelContext>(m, "ChannelContext") | |||
| .def_static( | |||
| // Still need a singleton as long as mambatest::singleton::channel_context is used | |||
There was a problem hiding this comment.
Wondering whether to leave this, or to take the opportunity to get rid of the ChannelContext singleton altogether.
There aren't that many breakage. The most annoying one is MatchSpec which now requires an explicit ChannelContext while this is something I wanted to get rid of (but we have so many things to do).
There was a problem hiding this comment.
I think we can keep it for now, but it would be nice to remove it before releasing 2.0
JohanMabille
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.