New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add expected caster to Union #3135

Merged

AntoinePrv merged 1 commit into mamba-org:main from AntoinePrv:expected-caster

Jan 17, 2024

Member

AntoinePrv commented Jan 17, 2024

Cast tl::expected<T, E> to a union of either T or E.
This is lesser effort that could later be enriched with method of and_then, value...

Even if the type may be unconventional in Python, casting it has several advatanges over throwing
exceptions.

Exception remains for expceptional cases and are not used for general control flow,
The API is closer to libmamba's,
It dimishes the glue code required to bind functions (as well as possible erorrs).


          Add expected caster to Union

e0d750e

JohanMabille approved these changes

View reviewed changes

Member Author

AntoinePrv commented Jan 17, 2024

Does not interfere with micromamba tests.

AntoinePrv merged commit cc95098 into mamba-org:main

21 checks passed

AntoinePrv deleted the expected-caster branch

January 17, 2024 15:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment