Mamba 2.0 name fixes #3225
Merged
Mamba 2.0 name fixes #3225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoinePrv
commented
Mar 13, 2024
Comment on lines
+712
to
+716
| validate_existing_root_prefix(default_root_prefix_v1()) | ||
| .or_else([](const auto& /* error */) | ||
| { return validate_root_prefix(default_root_prefix_v2()); }) | ||
| .transform([&](fs::u8path&& p) { prefix = std::move(p); }) | ||
| .or_else([](mamba_error&& error) { throw std::move(error); }); |
There was a problem hiding this comment.
Here we change the default root prefix (in case nothing is specified or found) to ~/.local/share/mamba.
AntoinePrv
commented
Mar 13, 2024
Comment on lines
+210
to
+216
| lines = res.splitlines() | ||
| assert "cmd.exe already initialized." in lines | ||
| # TODO test deactivated when enabled micromamba as "mamba" executable. | ||
| # The test failed for some reason. | ||
| # We would like a more controlled way to test long path support than into an | ||
| # integration test. | ||
| # assert "Windows long-path support already enabled." in lines |
There was a problem hiding this comment.
The assertion that is failing for untraceable reasons.
JohanMabille
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving all executable names (in scripts files for instance) to be compatible with
mamba.