1.x: retain add_channel_specific_matchspec between create_whatprovides calls #3232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tl-hbk
changed the title
AntoinePrv
approved these changes
Mar 14, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
conda/conda-libmamba-solver#447
conda-libmamba-solverreuses the same pool between solve attempts but creates a new solver each attempt. The solver initialization callscreate_whatprovidesand wipes the whatprovides relationships added for the channel specific matchspecs.The problem with this is that the channel specific match spec is still present in the pool's string cache so later
add_jobscalls just return the id for the channel specific match spec without readding the wiped whatprovides